Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DMVP-5087): upgrade waf module #347

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(DMVP-5087): upgrade waf module #347

merged 1 commit into from
Aug 23, 2024

Conversation

mrdntgrn
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Aug 23, 2024

📝 PR Summary

A lot has been improved in this update to enhance how we set up and manage our Web Application Firewall (WAF) service on AWS! 🎉 Let's discuss the improvements.

  • The readme and WAF setup files have been updated
    Now, the first line in modules/waf/README.md clearly declares what the module does, which increases understanding. Some specific settings in the modules have been tweaked for better optimization. Furthermore, the versions of the alerts and dashboard monitoring modules that we use have been updated to the latest, offering us new features and stability🚀

  • Added an option to disable alarms in test cases
    In our test cases files 1-example.tf for both "block" mode and "count" setup of our WAF service, you now have the ability to disable alarm notifications, giving more control over when and how you get notified!🔕

  • Updated the AWS provider version in test documentation
    The AWS provider versions in various test README files are now up to date. This ensures our resources are managed using the latest features and improvements from AWS.✨

  • Removal of Unused Test Assertions
    Any unnecessary test files such as 2-assert.tf which may no longer be relevant have been cleaned up. This declutters our code base, making it simpler and easier to navigate! 🧹✅

  • Environment Setup for Alarm Overdrive Tests
    A new setup file 0-setup.tf has been added for testing alarm overdrive. This improves our testing structure and helps us make sure alarms behave as expected in various situations.🚨

  • Renaming and Updating Test Files
    The main test file in the overwrite-alarms dir now has a more specific name, 1-example.tf, closely matching our naming conventions and providing a uniform code structure in our project, making it easy-peasy to find and understand the files.🔎

  • Added new version management file
    A new file, versions.tf, has been added to our WAF module. This will help us manage and keep track of the versions of various dependencies in our project. This means ever more control and visibility over our environment 🎚️👍.

And that's the scoop! Happy coding. 💻😊

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

@mrdntgrn mrdntgrn merged commit 0cb5974 into main Aug 23, 2024
123 of 183 checks passed
@mrdntgrn mrdntgrn deleted the DMVP-5087-upgrade-waf branch August 23, 2024 13:54
Copy link

🎉 This PR is included in version 2.15.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

Output

check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant