Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMVP-0000: Initial PR #62

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

DMVP-0000: Initial PR #62

wants to merge 19 commits into from

Conversation

viktoryathegreat
Copy link
Contributor

Terraform generated PR for best practices changes

@github-actions
Copy link

💰 Infracost estimate: monthly cost will not change

This comment will be updated when the cost estimate changes.

@what-the-diff
Copy link

what-the-diff bot commented Oct 13, 2023

PR Summary

  • Dependabot Configuration Added
    • Included .github/dependabot.yaml file supports automated dependency updates.
  • Branch Naming Enforcement Workflow Introduced
    • .github/workflows/branch-name-check.yaml mandates strict branch naming rules for more orderly management.
  • Checkov Action Update and Error Continuation
    • checkov.yaml workflow now uses the updated Checkov action (version 4.2.0). An added continue-on-error flag lets the workflow proceed amidst errors.
  • Infracost Workflow Addition
    • .github/workflows/infracost.yaml allows the automated generation of cost estimates, sending them as comments to pull requests.
  • Pull Request Title Checker Workflow Implementation
    • Added .github/workflows/pr-title-checker.yaml. This maintains proper title naming conventions for Pull Requests.
  • Pre-Commit Action Updated and Path Modified
    • The pre-commit.yaml workflow now leverages version 4.2.0 of the pre-commit action. A new continue-on-error flag allows task continuity despite interruptions. Additionally, the path parameter has been changed to include the modules/ prefix.
  • Use of Setup-Node Action Updated in Semantic-Release
    • semantic-release.yaml now taps into the third version of the setup-node action.
  • Terraform Test Action Update and Error Continuation
    • The terraform-test.yaml workflow uses version 4.2.0 of the terraform-test action, and the inclusion of a continue-on-error flag ensures workflow progress despite errors.
  • TFLint and TFSec Actions Update and Error Continuation
    • The tflint.yaml and tfsec.yaml workflows are updated to use version 4.2.0 of respective actions. Continue-on-error flags have been added to guarantee continuous workflow action.
  • Commit Message Script Typo Rectification and Status Code Update
    • A typo in the githooks/commit-msg script has been corrected, and the exit status code has been adjusted accordingly.

@github-actions
Copy link

Output

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/qoomon/git-conventional-commits.
[INFO] Initializing environment for https://github.com/zricethezav/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/zricethezav/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for added large files..............................................Passed
check for merge conflicts................................................Passed
check vcs permalinks.....................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing .github/workflows/checkov.yaml
Fixing .github/workflows/infracost.yaml
Fixing .github/workflows/terraform-test.yaml
Fixing .github/workflows/tflint.yaml

check yaml...............................................................Passed
check for merge conflicts................................................Passed
check for case conflicts.................................................Passed
mixed line ending........................................................Passed
detect aws credentials...................................................Passed
detect private key.......................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Failed
- hook id: terraform_docs
- files were modified by this hook
Detect hardcoded secrets.................................................Passed

Copy link

github-actions bot commented Nov 1, 2023

This PR has been automatically marked as stale because it has been open 90 days
with no activity. Remove stale label or comment why we need this.

@github-actions github-actions bot added the stale label Nov 1, 2023
@github-actions github-actions bot removed the stale label Dec 1, 2023
Copy link

github-actions bot commented Jan 1, 2024

This PR has been automatically marked as stale because it has been open 90 days
with no activity. Remove stale label or comment why we need this.

@github-actions github-actions bot added the stale label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant