Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bower support #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding bower support #172

wants to merge 1 commit into from

Conversation

Traksewt
Copy link

added bower component file. License property needs to be updated.

@dasmoth
Copy link
Owner

dasmoth commented Jul 16, 2015

Thanks for this.

However (and possibly I'm misunderstanding this -- I don't use bower myself) I'm not clear how the compilation step is meant to run in order to build dalliance-all.js and worker-all.js. When I looked into this previously, the done thing appeared to be to check compiled javascript assets into the project's main git repository (which I'm very reluctant to do, because including a bunch of old compiled versions will end up bloating git checkouts for everyone)

Potentially there could be a separate bower-specific repository?

Or am I missing something?

@doomedramen
Copy link
Contributor

I have 'dalliance-dist' on bower at the moment but I am unable to update it as dalliance fails to build for me on recent versions of node+npm

@dasmoth
Copy link
Owner

dasmoth commented Dec 19, 2015

@wookoouk sorry about this, the sands seem to have shifted rather a lot underneath the original build system. I'm updating it at the moment.

@dasmoth
Copy link
Owner

dasmoth commented Dec 20, 2015

I've updated the dependencies and build system. This ended up requiring a change from Google Closure Compiler -> Uglify (which I was a little nervous about, but output size hasn't changed much and I can't see any evidence of performance regressions).

Give me a shout if you see any problems. I'll switch to doing releases (which will probably be called 0.14.x) using this system after Christmas.

@doomedramen
Copy link
Contributor

I have update 'dalliance-dist' to use the latest changes.

install it with bower install dalliance-dist --save

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants