Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5.0 introduces javax.annotation through shrinkwrap 2.0.0-beta-2 #160

Closed
evandongen opened this issue Oct 8, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@evandongen
Copy link

Describe the bug

In our project we use the maven enforcer to ban javax.* dependencies. After a dependabot update for testcontainers-keycloak from 3.4.0 to 3.5.0, it fails because javax.activation:jar:1.2.0 is now a (transitive) dependency

We recently migrated our project to use jakarta.* dependencies, which worked like a charm with 3.4.0. Perhaps this is an unwanted side-effect from the shrinkwrap 1.2.6 --> 2.0.0-beta-2 update? I have fixed it for now in our codebase with using an exclusion in the pom file.

Version

3.5.0

Expected behavior

Our maven build works without excluding javax.annotation in the pom.xml

Actual behavior

The build fails due to 3.5.0 introducing javax.annotation dependency through shrinkwrap 2.0.0 beta 2.

How to Reproduce?

No response

Relevant log output

Error:  Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce-lib-ban) on project frankframework-core: 
Error:  Rule 4: org.apache.maven.enforcer.rules.dependency.BannedDependencies failed with message:
Error:  Don't touch versions, we should use jakarta.activation-api:2.1.3
Error:  org.frankframework:frankframework-core:jar:8.3.0-SNAPSHOT
Error:     com.github.dasniko:testcontainers-keycloak:jar:3.5.0
Error:        org.jboss.shrinkwrap:shrinkwrap-impl-base:jar:2.0.0-beta-2
Error:           com.sun.activation:javax.activation:jar:1.2.0 <--- banned via the exclude/include list

Anything else?

No response

@dasniko
Copy link
Owner

dasniko commented Oct 8, 2024

Thx for reporting.
I'll investigate today and do a new patch release if easily possible. Hopefully just excluding the javax.activation dependency is enough.

@dasniko dasniko self-assigned this Oct 8, 2024
@evandongen
Copy link
Author

It is for now, but I just wanted to report it as well!

dasniko added a commit that referenced this issue Oct 8, 2024
resolves #160

Signed-off-by: Niko Köbler <niko@n-k.de>
@dasniko dasniko closed this as completed Oct 8, 2024
dasniko added a commit that referenced this issue Oct 8, 2024
resolves #160

Signed-off-by: Niko Köbler <niko@n-k.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants