Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyperdb (and multiwriter) for deleted flag and HypercoreProtocol header #50

Merged
merged 3 commits into from
Jan 2, 2019

Conversation

bnewbold
Copy link
Contributor

@bnewbold bnewbold commented Nov 17, 2018

Rendered: hyperdb, multiwriter

These are some extremely-procrastinated changes to the hyperdb DEP (currently in "Draft" status) to support:

  • the deleted flag instead of setting value to null for deletions
  • note that a HypercoreProtocol message with protocol string hyperdb should be the first message in every hyperdb feed (as per DEP-0007: Hypercore Header)

Along the way I also:

  • updated examples (in both hyperdb and multiwriter DEPs) to be consistent with a HypercoreProtocol header message at entry index 0. Math/typos could probably use a second set of eyes... maybe @yoshuawuyts could take a look?
  • talked about the Entry/InflatedEntry distinction in the hyperdb DEP. I think the previous state of referring to a single Entry schema that matched the actual InflatedEntry was confusing.

The bulk of this commit is updating the examples with incremented
indices. The math could use review.
@bnewbold
Copy link
Contributor Author

cc: @mafintosh @pfrazee

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liking the changes! Left some comments, but this is looking good overall! Nice! 🎉

@pfrazee
Copy link
Contributor

pfrazee commented Nov 18, 2018

👍 No additional comments from me

@bnewbold bnewbold merged commit 75e0eff into dat-ecosystem-archive:master Jan 2, 2019
@bnewbold bnewbold deleted the bnewbold-hyperdb3 branch January 2, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants