Add support for streaming non-encoded binaries from plugins #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for harvesting non-encoded/enveloped binary evidence values from plugins, which performs better on larger non-structured files since we avoid a lot of JSON marshalling. This also implements streaming of said binaries, however the out-of-process functions model does not yet support this, so the entire content needs to be buffered on each hop (plugin worker -> plugin host -> core worker -> core host -> client). This causes significant delay before the first byte is received at the client. This change, however, by avoiding Base64-encoding, mitigates this.