Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for streaming non-encoded binaries from plugins #31

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

elsand
Copy link
Member

@elsand elsand commented Feb 9, 2023

Description

This adds support for harvesting non-encoded/enveloped binary evidence values from plugins, which performs better on larger non-structured files since we avoid a lot of JSON marshalling. This also implements streaming of said binaries, however the out-of-process functions model does not yet support this, so the entire content needs to be buffered on each hop (plugin worker -> plugin host -> core worker -> core host -> client). This causes significant delay before the first byte is received at the client. This change, however, by avoiding Base64-encoding, mitigates this.

@elsand elsand requested a review from erlendoksvoll February 20, 2023 11:40
Copy link
Member

@erlendoksvoll erlendoksvoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elsand elsand merged commit b08fb03 into master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants