-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Python scalars in array_namespace #147
base: main
Are you sure you want to change the base?
Conversation
They are just ignored. This makes array_namespace easier to use for functions that accept either arrays or scalars. I'm not sure if I should have this behavior by default, or if it should be enabled by a flag.
We can also automatically ignore |
I would say this should be opt-in, given the standard really focusses on just arrays. In practice, it will probably be used more often than not (at least for now), but given that (for now) most projects will wrap In SciPy, it doesn't really matter either way as we coerce scalars to NumPy arrays before passing them to |
There are some active discussions on allowing scalars in more places in the array API. See data-apis/array-api#805 and data-apis/array-api#807.
I'm trying to make that not the case. Some projects like SciPy will have specific reasons they'll need to wrap things, but ideally whatever most projects need should be implemented already in the wrappers here. |
I think another form of wrapping that will be very common is using a default backend when all arguments of |
That would be easy to add. I would caution against it though unless you are doing it for backwards compatibility. If you default to NumPy, for instance, you could end up in a situation where a user gets a NumPy array from one function because they passed in scalars, and another array from another function because they passed in arrays. |
Yeah, I'm thinking that the reason would be to maintain BC |
They are just ignored. This makes array_namespace easier to use for functions that accept either arrays or scalars.
I'm not sure if I should have this behavior by default, or if it should be enabled by a flag.