Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add top_k compatibility #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JuliaPoo
Copy link

This references the PR data-apis/array-api-tests#274 and implements the compatibility layer for top_k.

Summary of Compatibility

Process

As mentioned in the referenced PR, since the process I went through is likely going to be repeated again, here are the steps I took:

  • Create a branch for array-api that adds the corresponding specification.
    • I added the spec in .draft.
  • Create a branch for array-api-tests which implements the new tests and has its array-api submodule pointing to the newly created array-api branch.
    • Being new to submodules, changing the submodule took me forever to debug.
  • Create a branch for array-api-compat (This PR) that implements the compatibility and points the CI to the newly created array-api-tests branch.
    • Add the environment variable ARRAY_API_TESTS_VERSION=draft in the CI.

Since I was implementing tests and compatibility on a non-existent spec, developing all 3 concurrently was incredibly messy. As of now I don't have much opinions on how to improve this process, but a documentation page of the necessary steps will be really helpful for future contributors.

@JuliaPoo JuliaPoo changed the title WIP: Add top_k compatibility WIP: Add top_k compatibility [DO NOT MERGE] Jun 27, 2024
@JuliaPoo JuliaPoo changed the title WIP: Add top_k compatibility [DO NOT MERGE] WIP: Add top_k compatibility Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant