Skip to content

TST: run parameterized tests on more libraries #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

TST: run parameterized tests on more libraries #227

merged 1 commit into from
Jan 24, 2025

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Jan 6, 2025 •
edited
Loading

Q: (out of scope) shouldn't we add an is_array_api_strict_array function, to match is_array_api_strict_namespace?

This was referenced Jan 6, 2025
Merged
Merged
@crusaderky crusaderky changed the title Run more tests on array-api-strict and sparse ENH: Better ndonnx support; run more tests on ndonnx, array-api-strict, and sparse Jan 8, 2025
@crusaderky crusaderky changed the title ENH: Better ndonnx support; run more tests on ndonnx, array-api-strict, and sparse ENH: Better ndonnx support; run parameterized tests on more libraries Jan 8, 2025
@crusaderky crusaderky changed the title ENH: Better ndonnx support; run parameterized tests on more libraries ENH: ndonnx device; run parameterized tests on more libraries Jan 8, 2025
@crusaderky crusaderky force-pushed the test_more_backends branch 3 times, most recently from d8019e5 to 4e7603a Compare January 8, 2025 12:15
@crusaderky crusaderky changed the title ENH: ndonnx device; run parameterized tests on more libraries TST: run parameterized tests on more libraries Jan 8, 2025
@crusaderky crusaderky mentioned this pull request Jan 8, 2025
Merged
@crusaderky crusaderky closed this Jan 14, 2025
@crusaderky crusaderky reopened this Jan 14, 2025
@crusaderky crusaderky force-pushed the test_more_backends branch 2 times, most recently from 624ae63 to f321555 Compare January 16, 2025 13:31
@crusaderky
Copy link
Contributor Author

@ev-br this is ready for review and merge

@crusaderky crusaderky mentioned this pull request Jan 23, 2025
Closed
lucascolley
lucascolley approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Q: (out of scope) shouldn't we add an is_array_api_strict_array function, to match is_array_api_strict_namespace?

Yes

@lucascolley lucascolley merged commit d6f431d into data-apis:main Jan 24, 2025
42 checks passed
@crusaderky crusaderky deleted the test_more_backends branch January 24, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascolley lucascolley lucascolley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @lucascolley