Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: drop python 3.9, numpy 1.21 #266

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

CI: drop python 3.9, numpy 1.21 #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46913ef
CI: drop python 3.9, numpy 1.21
ev-br Mar 3, 2025
6e1502c
CI: drop python 3.10, add python 3.13
ev-br Mar 3, 2025
d0ef320
CI: trim self-tests
ev-br Mar 3, 2025
e5da2ca
CI: test with python 3.10
ev-br Mar 23, 2025
3587115
CI: Use python 3.10 in self-tests, too
ev-br Mar 23, 2025
3ef81ed
Merge branch 'main' into upd_ci
ev-br Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .github/workflows/array-api-tests-numpy-1-21.yml
View file
Open in desktop

This file was deleted.

12 changes: 5 additions & 7 deletions .github/workflows/array-api-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# Min version of dask we need dropped support for Python 3.9
# There is no numpy git tip for Python 3.9 or 3.10
python-version: ${{ (inputs.package-name == 'dask' && fromJson('[''3.10'', ''3.11'', ''3.12'']')) || (inputs.package-name == 'numpy' && inputs.xfails-file-extra == '-dev' && fromJson('[''3.11'', ''3.12'']')) || fromJson('[''3.9'', ''3.10'', ''3.11'', ''3.12'']') }}
python-version: ['3.10', '3.12', '3.13']

steps:
- name: Checkout array-api-compat
Expand All @@ -65,15 +63,15 @@ jobs:
run: |
echo "${{ inputs.extra-env-vars }}" >> $GITHUB_ENV
- name: Install dependencies
# NumPy 1.21 doesn't support Python 3.11. There doesn't seem to be a way
# to put this in the numpy 1.21 config file.
if: "! ((matrix.python-version == '3.11' || matrix.python-version == '3.12') && inputs.package-name == 'numpy' && contains(inputs.package-version, '1.21'))"
# NumPy 1.26 doesn't support Python 3.13. There doesn't seem to be a way
# to put this in the numpy 1.26 config file.
Comment on lines +66 to +67
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just use an exclude: directive like in tests.yml below?

if: "! (matrix.python-version == '3.13' && inputs.package-name == 'numpy' && contains(inputs.package-version, '1.26'))"
run: |
python -m pip install --upgrade pip
python -m pip install '${{ inputs.package-name }} ${{ inputs.package-version }}' ${{ inputs.extra-requires }}
python -m pip install -r ${GITHUB_WORKSPACE}/array-api-tests/requirements.txt
- name: Run the array API testsuite (${{ inputs.package-name }})
if: "! ((matrix.python-version == '3.11' || matrix.python-version == '3.12') && inputs.package-name == 'numpy' && contains(inputs.package-version, '1.21'))"
if: "! (matrix.python-version == '3.13' && inputs.package-name == 'numpy' && contains(inputs.package-version, '1.26'))"
env:
ARRAY_API_TESTS_MODULE: array_api_compat.${{ inputs.module-name || inputs.package-name }}
ARRAY_API_TESTS_VERSION: 2024.12
Expand Down
16 changes: 6 additions & 10 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.9', '3.10', '3.11', '3.12']
numpy-version: ['1.21', '1.26', '2.0', 'dev']
python-version: ['3.10', '3.12']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: ['3.10', '3.12']
python-version: ['3.10', '3.12', '3.13']

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.12 testing can be dropped from CI?

Copy link
Contributor

@crusaderky crusaderky Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not if you want to test numpy 1.26 on the most recent python version it supports.
But yes, we could run on 3.12 for numpy 1.x and on 3.13 for everything else.

numpy-version: ['1.26', 'latest', 'dev']
exclude:
- python-version: '3.11'
numpy-version: '1.21'
- python-version: '3.12'
numpy-version: '1.21'
- python-version: '3.13'
numpy-version: '1.26'
fail-fast: true
steps:
- uses: actions/checkout@v4
Expand All @@ -23,17 +21,15 @@ jobs:
python -m pip install --upgrade pip
if [ "${{ matrix.numpy-version }}" == "dev" ]; then
PIP_EXTRA='numpy --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple'
elif [ "${{ matrix.numpy-version }}" == "1.21" ]; then
PIP_EXTRA='numpy==1.21.*'
else
elif [ "${{ matrix.numpy-version }}" == "1.26" ]; then
PIP_EXTRA='numpy==1.26.*'
fi

python -m pip install .[dev] $PIP_EXTRA

- name: Run Tests
run: |
if [[ "${{ matrix.numpy-version }}" == "1.21" || "${{ matrix.numpy-version }}" == "dev" ]]; then
if [[ "${{ matrix.numpy-version }}" == "dev" ]]; then
PYTEST_EXTRA=(-k "numpy and not jax and not torch and not dask and not sparse")
fi
pytest -v "${PYTEST_EXTRA[@]}"
Expand Down
Loading