Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: release 1.11.2 branch #280

Merged
merged 4 commits into from
Mar 20, 2025
Merged

REL: release 1.11.2 branch #280

merged 4 commits into from
Mar 20, 2025

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Mar 20, 2025

No description provided.

@ev-br ev-br force-pushed the release_1.11.2 branch 2 times, most recently from e7f3dcd to 6cc41dd Compare March 20, 2025 12:27
@ev-br
Copy link
Member Author

ev-br commented Mar 20, 2025

I'm going to ignore

@ev-br ev-br deployed to publish-package March 20, 2025 13:10 — with GitHub Actions Active
@ev-br
Copy link
Member Author

ev-br commented Mar 20, 2025

I'm going to ignore ...

heh, the release is out on PyPI but these flaky/irrelevant failures block finishing the release process: this PR cannot be merged because branch protection rules :-)).

So PSA: main is blocked for merging until this mess is dealt with :-).

NumPy < 2 fails to promote an empty f32 array with a scalar, returns an empty f64 array
@rgommers
Copy link
Member

So PSA: main is blocked for merging until this mess is dealt with :-).

How about we turn off that part of the branch protection? It's been a repeated mess, and I can't think of any other project I work on that doesn't allow committers to ignore flaky failures or known issues.

@rgommers
Copy link
Member

I've done that now, because a release from an unmerged PR is quite bad. @ev-br this is mergeable now. I didn't review, but trust you can make the right decision here.

@ev-br
Copy link
Member Author

ev-br commented Mar 20, 2025

Thanks Ralf! This is really helpful.

A few hours later, and with a couple of fixes to the test suite, we're down to: one failure on numpy 1.21, and a new failure from ruff (which made a release several hours ago), telling us that array-api-compat code is using type annotations in a way incompatible with python 3.9.
I'm not going to spend time on either of these now. Merging to close the book on 1.11.x.

@ev-br ev-br merged commit a479293 into data-apis:main Mar 20, 2025
40 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants