Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for torch linalg extension #35

Merged
merged 6 commits into from
Mar 31, 2023

Conversation

asmeurer
Copy link
Member

Mostly minor stuff, like incorrect type promotion or some functions not supporting integer dtypes.

@asmeurer asmeurer requested a review from lezcano March 28, 2023 15:34
Copy link

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a general note, but it's not directly related to this PR.

Comment on lines +35 to +38
x1_shape = (1,)*(ndim - x1.ndim) + tuple(x1.shape)
x2_shape = (1,)*(ndim - x2.ndim) + tuple(x2.shape)
if x1_shape[axis] != x2_shape[axis]:
raise ValueError("x1 and x2 must have the same size along the given axis")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These semantics allow for a weird construction like vecdot(xp.randn(1,4,5,6), xp.randn(6), axis=0) which would be equivalent to xp.randn(1,4,5,6) * xp.randn(6). This may be a discussion for the general broadcasting rules for the API, but perhaps you want that to assert that all(x.ndim - 1 >= axis for x in input_tensors) (perhaps with some special treatment for 0-dim tensors).

Copy link
Member Author

@asmeurer asmeurer Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think about it, I wonder if this sort of thing should already be disallowed by the spec. https://data-apis.org/array-api/latest/API_specification/generated/array_api.vecdot.html#array_api.vecdot

I've been working on the assumption that axis refers to the dimension after broadcasting ("Must be an integer on the interval [-N, N), where N is the rank (number of dimensions) of the shape determined according to Broadcasting."). But it also says "The contracted axis (dimension) must not be broadcasted."

I had been interpreting that as meaning you shouldn't allow something like vecdot(empty((3, 3)), empty((1, 3)), axis=0). But I suppose it could also be taken to mean that broadcasting shouldn't "broadcast up" to the contracted dimension either. Something more along the lines of

if axis >= 0:
    ndim = max(x.ndim for x in inputs)
    if any(axis < ndim - x.ndim for x in inputs):
        raise ValueError("Contracted axis cannot be broadcasted")

(e.g., vecdot(empty((1, 2, 3, 4, 5)), empty((3, 4, 5)), axis=2) is fine but vecdot(empty((1, 2, 3, 4, 5)), empty((3, 4, 5)), axis=0) is not)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think disallowing both (not broadcast along the reduced dimension and ask for the axis to be well defined in the sense you just described) would be the safer thing to do, as otherwise you end up with these funny constructions, which is not great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an issue in all the other implementations too, and arguably the spec as well. I'm going to deal with it in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants