CI: Quote regex to avoid syntax error #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Regex on tag must be quoted to avoid YAML syntax error.
Contributor
Author
|
Evidence that this works and you won't have to keep dealing with slightly wrong CI: $ git diff origin/ci/fix-regex
diff --git a/.github/workflows/publish-package.yml b/.github/workflows/publish-package.yml
index 35f087d..91a276f 100644
--- a/.github/workflows/publish-package.yml
+++ b/.github/workflows/publish-package.yml
@@ -3,6 +3,7 @@ on:
push:
branches:
- main
+ - debug/workflow
tags:
- '[0-9]+.[0-9]+'
- '[0-9]+.[0-9]+.[0-9]+'
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends PR #51
@asmeurer The CI is failing on merge to
mainas when you added the regex for the tags to PR #51 I didn't check it on my fork (when debugging I had removed the branch and tag block to run onpush). The regex needs to be quoted, else a YAML syntax error occurs.