Some fixes for torch.linalg wrappers #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not properly imported, and also torch.cross does not broadcast correctly in all cases.
- torch.vecdot incorrectly allows broadcasting in the contracted dimensions - The 2023 version of the spec updates the language to require axis to apply before broadcasting, not after. The implementation for integer arguments is updated to follow this behavior. Note that the spec only actually requires axis to be negative, but we allow nonnegative axis too if x1 and x2 have the required number of dimensions and those dimensions have same value, which matches the numpy gufunc vecdot implementation and also the base torch.vecdot implementation as far as I can tell.
This is changed in the 2023 version of the spec, and matches the new np.vecdot gufunc.
Also cleanup the torch.linalg __all__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These came up from data-apis/array-api-tests#101.