ENH: at support for bool mask in Dask and JAX
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
changed the title
at support for bool mask in Dask and JAXat support for bool mask in Dask and JAX
crusaderky
force-pushed
the
at_bool_mask
branch
2 times, most recently
from
4863400 to
6bb7d96
Compare
crusaderky
force-pushed
the
at_bool_mask
branch
from
6bb7d96 to
b69c945
Compare
crusaderky
commented
Jan 24, 2025
|
|
||
| You should instead use:: | ||
|
|
||
| >>> x = xp.where(m(x), f(x), x) |
There was a problem hiding this comment.
TODO suggest to use lazywhere
|
@lucascolley ready for review! |
lucascolley
reviewed
Jan 25, 2025
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
NeilGirdhar
pushed a commit
to NeilGirdhar/array-api-extra
that referenced
this pull request
Feb 20, 2025
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This special case treatment should be incorporated inside jax itself.
In the meantime, for the sake of expedience, I'm implementing it here.