Skip to content

MAINT: depend on array-api-compat #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Dec 6, 2024

Follow-up: vendoring hook in scipy

@lucascolley
Copy link
Member

WIP: vendoring hook in scipy (if you merge this now, scipy will break!)

Note that this will break all third-party libraries that vendor array-api-extra through a unpinned git subproject, like scipy does.

Why? I was under the impression that "unpinned" git submodules are not bumped unless someone deliberately does so. All of SciPy's git submodules are unpinned.

@crusaderky
Copy link
Contributor Author

I was under the impression that "unpinned" git submodules are not bumped unless someone deliberately does so

I wasn't aware of that, good to know

@crusaderky crusaderky force-pushed the array-api-compat branch 2 times, most recently from 7be17b2 to 82a3b6d Compare December 6, 2024 14:31
@lucascolley
Copy link
Member

lucascolley commented Dec 6, 2024

I think we will want to document somewhere what we are relying on from array-api-compat, or otherwise indicate which versions of array-api-compat this can depend on or be co-vendored with.

I think I'm fine with something along the lines of "we aim for compatibility with the latest released version of array-api-compat, and your mileage may vary with older or dev versions".

@crusaderky crusaderky force-pushed the array-api-compat branch 2 times, most recently from 494064b to b06cbcc Compare December 6, 2024 14:51
@crusaderky
Copy link
Contributor Author

@lucascolley this is ready for review. Could you please enable workflows for this PR?

@crusaderky crusaderky changed the title [WIP] Add dependency to array-api-compat Add dependency to array-api-compat Dec 6, 2024
@crusaderky crusaderky marked this pull request as ready for review December 6, 2024 14:52
@crusaderky
Copy link
Contributor Author

Could you please unlock this?
image

@crusaderky
Copy link
Contributor Author

I executed rm pixi.lock && pixi run tests to update the lock; not sure if it's the correct process?

@lucascolley
Copy link
Member

rm pixi.lock && pixi run tests

pixi update should do

Could you please unlock this?

Unfortunately, I believe manual approval has to be given every time, for first-time contributors. Feel free to submit a separate PR with a trivial change if you want to unblock that.

@lucascolley
Copy link
Member

looks like you may want to bump the version of pixi used by the CI workflows, if your local version is newer

@crusaderky
Copy link
Contributor Author

Feel free to submit a separate PR with a trivial change if you want to unblock that.

#48

@crusaderky
Copy link
Contributor Author

I've rebased this PR on top of #48 to get a more readable pixi.lock diff

@crusaderky
Copy link
Contributor Author

@lucascolley all green; ready for final review and merge

Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @crusaderky, this looks great!

I suppose the scope of this package expanding is a blessing and a curse :). We will need to update the 'scope' section of the docs, but I'm happy to tackle this separately.

@crusaderky
Copy link
Contributor Author

@lucascolley all comments addressed; this should be ready for merge

@lucascolley lucascolley changed the title Add dependency to array-api-compat MAINT: depend on array-api-compat Dec 9, 2024
@lucascolley lucascolley merged commit 09dc648 into data-apis:main Dec 9, 2024
10 checks passed
@crusaderky crusaderky deleted the array-api-compat branch December 9, 2024 13:41
@lucascolley
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH/API: xp-bound namespaces, array-api-compat
2 participants