Fix the pinv function, which was implicitly using __array__

data-apis · Oct 31, 2024 · d630ee5 · d630ee5
1 parent bb28167
commit d630ee5
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/array_api_strict/_linalg.py b/array_api_strict/_linalg.py
@@ -267,6 +267,8 @@ def pinv(x: Array, /, *, rtol: Optional[Union[float, Array]] = None) -> Array:
     # default tolerance by max(M, N).
     if rtol is None:
         rtol = max(x.shape[-2:]) * finfo(x.dtype).eps
+    if isinstance(rtol, Array):
+        rtol = rtol._array
     return Array._new(np.linalg.pinv(x._array, rcond=rtol), device=x.device)
 
 @requires_extension('linalg')