Add preliminary support for the draft 2024.12 version of the standard #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how to make this depend on API version so for now it's just there always.
This makes it so that it doesn't have a bunch of extra names on it, which it did as a module.
As far as I can tell, NumPy matches the standard specification, except for the fact that NumPy does not set a default value for axis.
This was referenced Nov 5, 2024
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 suggestion.
Files not reviewed (5)
- array_api_strict/_typing.py: Evaluated as low risk
- array_api_strict/init.py: Evaluated as low risk
- array_api_strict/tests/test_array_object.py: Evaluated as low risk
- array_api_strict/tests/test_elementwise_functions.py: Evaluated as low risk
- array_api_strict/_elementwise_functions.py: Evaluated as low risk
| @@ -25,3 +26,14 @@ def take(x: Array, indices: Array, /, *, axis: Optional[int] = None) -> Array: | |||
| if x.device != indices.device: | |||
| raise ValueError(f"Arrays from two different devices ({x.device} and {indices.device}) can not be combined.") | |||
| return Array._new(np.take(x._array, indices._array, axis=axis), device=x.device) | |||
|
|
|||
| @requires_api_version('2024.12') | |||
| def take_along_axis(x: Array, indices: Array, /, *, axis: int = -1) -> Array: | |||
There was a problem hiding this comment.
The function take_along_axis should check that indices.dtype is in _integer_dtypes to ensure only integer indices are allowed.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.