Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Require NumPy >= 2.1" #90

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Revert "Require NumPy >= 2.1" #90

merged 3 commits into from
Nov 8, 2024

Conversation

asmeurer
Copy link
Member

@asmeurer asmeurer commented Nov 8, 2024

Apparently this is causing issues with some libraries (for example, pydata/xarray#9750, because numba doesn't support NumPy 2.0 yet IIUC)

Reverts #87

@asmeurer asmeurer requested review from Copilot and rgommers November 8, 2024 20:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • requirements-dev.txt: Language not supported
  • array_api_strict/init.py: Evaluated as low risk
  • setup.py: Evaluated as low risk
Comments skipped due to low confidence (1)

array_api_strict/tests/test_array_object.py:451

  • [nitpick] The function name was changed from 'dlpack_2023_12' to 'test_dlpack_2023_12'. Ensure that the new name is consistent with the naming conventions used in the rest of the test suite.
def test_dlpack_2023_12(api_version):
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @asmeurer! Straight revert seems like a good choice - this can be delayed.

@asmeurer asmeurer merged commit 4e5ff09 into main Nov 8, 2024
39 checks passed
@asmeurer asmeurer deleted the revert-87-require-numpy-2 branch November 8, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants