Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking remaining 2022.12 test suite coverage #193

Open
2 of 3 tasks
honno opened this issue Jul 24, 2023 · 2 comments
Open
2 of 3 tasks

Tracking remaining 2022.12 test suite coverage #193

honno opened this issue Jul 24, 2023 · 2 comments

Comments

@honno
Copy link
Member

honno commented Jul 24, 2023

The test suite has excellent coverage of the first 2021.12 spec release, but hasn't been updated to cover all the 2022.12 additions and changes. The following is a list of things that ideally the test suite would do:

  • Bump array-api submodule #187
  • Test the fft extension
    • We definitely want to at least test the dtype and broadcasting behaviour of these functions—and by virtue, smoke test them with valid inputs. Values testing is non-trivial enough to probably not be worth doing.
@honno
Copy link
Member Author

honno commented Jul 24, 2023

Ofc @asmeurer and folks feel free to edit the original post, this is just what immediately came to mind.

@asmeurer
Copy link
Member

The submodule thing also prevents the signature tests for working with any signature updates post 2022.12

We'll need to check with how the scipy stuff is going, but it's likely we'll want to prioritize fft testing, so that we can implement it numpy.array_api (numpy/numpy#23892) and the compat library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@asmeurer @honno and others