You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here's the current fft test failures for array_api_strict:
FAILED array_api_tests/test_fft.py::test_fft - TypeError: Only complex floating-point dtypes are allowed in fft
FAILED array_api_tests/test_fft.py::test_ifft - TypeError: Only complex floating-point dtypes are allowed in ifft
FAILED array_api_tests/test_fft.py::test_fftn - TypeError: Only complex floating-point dtypes are allowed in fftn
FAILED array_api_tests/test_fft.py::test_ifftn - TypeError: Only complex floating-point dtypes are allowed in ifftn
FAILED array_api_tests/test_fft.py::test_rfft - AssertionError: out.shape=(2,), but should be (3,) [rfft()]
FAILED array_api_tests/test_fft.py::test_irfft - AssertionError: out.dtype=float32, but should be complex64 [irfft(complex64)]
FAILED array_api_tests/test_fft.py::test_rfftn - AssertionError: out.shape=(2,), but should be (3,) [rfftn()]
FAILED array_api_tests/test_fft.py::test_irfftn - AssertionError: out.dtype=float32, but should be complex64 [irfftn(complex64)]
FAILED array_api_tests/test_fft.py::test_hfft - ExceptionGroup: Hypothesis found 2 distinct failures. (2 sub-exceptions)
FAILED array_api_tests/test_fft.py::test_ihfft - AssertionError: out.shape=(2,), but should be (4,) [ihfft()]
Some of the tests are still using real inputs for functions that are changed to only require complex.
The dtype checks in irfft and irfftn are also wrong. Those functions map complex -> real.
Finally, the shape checks seem to be wrong. The PR updates what the output shape should be for ihfft. The test expects an input shape of 3 to map to 4, but the output shape should be 2 == 3//2 + 1.
As far as I can tell, the array_api_strict/np.array_api implementation should be correct here, although someone will need to confirm whether the spec needs to be updated for rfft and rfftn.
The text was updated successfully, but these errors were encountered:
Some fft tests need to be updated from data-apis/array-api#720
Here's the current fft test failures for array_api_strict:
Some of the tests are still using real inputs for functions that are changed to only require complex.
The dtype checks in irfft and irfftn are also wrong. Those functions map complex -> real.
Finally, the shape checks seem to be wrong. The PR updates what the output shape should be for
ihfft
. The test expects an input shape of 3 to map to 4, but the output shape should be 2 == 3//2 + 1.The
rfftn
andrfft
shape tests are matching what the spec says, but I think that might also be wrong (or at least NumPy's implementation and documentation disagrees). See https://github.com/data-apis/array-api/pull/720/files#r1463962541 and https://github.com/data-apis/array-api/pull/720/files#r1463964686As far as I can tell, the array_api_strict/np.array_api implementation should be correct here, although someone will need to confirm whether the spec needs to be updated for
rfft
andrfftn
.The text was updated successfully, but these errors were encountered: