helpers: avoid mutation in invertible_matrices #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
force-pushed
the
fix-invertible-matrices
branch
from
9718896
to
bd4ab55
Compare
|
This looks fine. Generally I wouldn't want to make use of so many array functions in a strategy, but for the linalg strategies it's unavoidable and really not a problem to assume everything else works there. |
jakevdp
force-pushed
the
fix-invertible-matrices
branch
from
bd4ab55
to
3d71a51
Compare
|
CI errors are due to using an old version of NumPy; hopefully #202 will fix it. |
honno
force-pushed
the
fix-invertible-matrices
branch
from
3d71a51
to
7ce7b28
Compare
|
Let me know if there's anything to be done here – the reliance on in-place mutation in the test infrastructure here and elsewhere necessetates us skipping this test in JAX, so we don't have any test coverage for the associated linear algebra APIs. |
honno
force-pushed
the
fix-invertible-matrices
branch
from
7ce7b28
to
f81c3a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for #188