Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 2023.12 tests #262

Merged
merged 26 commits into from
Jun 25, 2024
Merged

Fixes for 2023.12 tests #262

merged 26 commits into from
Jun 25, 2024

Conversation

asmeurer
Copy link
Member

No description provided.

@asmeurer
Copy link
Member Author

Functions to prioritize:

  • unstack (new in NumPy)
  • clip (has a lot of corner cases)

@mtsokol
Copy link
Contributor

mtsokol commented Jun 10, 2024

I've got one question: Inspection functions shouldn't be in the main namespace but only in the __array_namespace_info__ namespace, as described in the standard (https://data-apis.org/array-api/latest/API_specification/inspection.html#inspection-apis), right?

@asmeurer
Copy link
Member Author

Yes, that's right.

@asmeurer
Copy link
Member Author

We still need a lot more test updates for 2023, but I'm going to merge this to make it easier for people to use.

@asmeurer asmeurer merged commit 809a198 into data-apis:master Jun 25, 2024
4 checks passed
@asmeurer
Copy link
Member Author

I can also tag a release, although I don't know if anyone is using that. The last release in this repo was tagged in 2022.

@mtsokol
Copy link
Contributor

mtsokol commented Jun 25, 2024

We still need a lot more test updates for 2023, but I'm going to merge this to make it easier for people to use.

Thank you! I think we don't need a release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants