Skip to content

Device support statement refinement #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oleksandr-pavlyk opened this issue Apr 7, 2021 · 2 comments · Fixed by #171
Closed

Device support statement refinement #157

oleksandr-pavlyk opened this issue Apr 7, 2021 · 2 comments · Fixed by #171
Assignees
Labels
topic: Device Handling Device handling.

Comments

@oleksandr-pavlyk
Copy link
Contributor

In the document device support we state

it is important to be able to control on which device newly created arrays get placed and where execution happens.

We do mention separate needs for array allocation control and execution control.

When describing the option 3 which this data API adopts, we only talk about allocation control:

  1. Local control via explicit keywords and a method to transfer arrays to another device.

I think it is important to explicitly add that the execution takes place local to the data, a.k.a. "computation follows data" convention.

So I suggest we modify item 3 to say

  1. Local control for data allocation target via explicit keywords, with convention that execution takes place on the same device where all argument arrays are allocated; methods for explicitly transferring data between devices.
@oleksandr-pavlyk
Copy link
Contributor Author

Additionally, the device support document we state that method ary.to_device(device) must be provided, but this method is not listed in the API specs document.

@rgommers rgommers self-assigned this Apr 8, 2021
@rgommers
Copy link
Member

rgommers commented Apr 8, 2021

This textual change makes sense, and we should indeed add the missing method. Thanks @oleksandr-pavlyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: Device Handling Device handling.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants