Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Consistency] Definition of the properties of the output #209

Closed
lezcano opened this issue Jun 29, 2021 · 1 comment · Fixed by #220
Closed

[Consistency] Definition of the properties of the output #209

lezcano opened this issue Jun 29, 2021 · 1 comment · Fixed by #220
Labels
topic: Linear Algebra Linear algebra.
Milestone
v2021

Comments

@lezcano
Copy link
Contributor

lezcano commented Jun 29, 2021 •
edited
Loading

Some functions such as linalg.qr define the properties that the outputs should have---Q orthogonal, R upper-triangular---but others such as linalg.eigh do not.

I believe that it would be best to specify the properties that these matrices should have in the definition of each function.

cc @rgommers @mruberry
@lezcano lezcano mentioned this issue Jun 29, 2021
Closed
@rgommers rgommers added the topic: Linear Algebra Linear algebra. label Jun 30, 2021
@rgommers
Copy link
Member

Makes sense to me to improve the descriptions here, thanks @lezcano .

@lezcano lezcano mentioned this issue Jul 9, 2021
Merged
@kgryte kgryte added this to the v2021 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2021
Development

Successfully merging a pull request may close this issue.

Make the writing of the factorisations in linalg more uniform lezcano/array-api
3 participants
@rgommers @kgryte @lezcano