Skip to content

Regarding return type of matrix_rank in Linear_Algebra module #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RickSanchezStoic opened this issue Aug 3, 2022 · 1 comment · Fixed by #510
Closed

Regarding return type of matrix_rank in Linear_Algebra module #469

RickSanchezStoic opened this issue Aug 3, 2022 · 1 comment · Fixed by #510
Labels
bug Something isn't working. topic: Linear Algebra Linear algebra.
Milestone
v2022

Comments

@RickSanchezStoic
Copy link

https://data-apis.org/array-api/latest/extensions/generated/signatures.linalg.matrix_rank.html states that the return type should be float. Is this correct? If so, why is that? All the frameworks : torch, TensorFlow , Jax return an int type or variant.
@kgryte kgryte added bug Something isn't working. topic: Linear Algebra Linear algebra. labels Aug 3, 2022
@kgryte
Copy link
Contributor

kgryte commented Aug 3, 2022

@RickSanchezStoic Thanks for filing this issue. You are correct. The return type should be the default integer data type.

rgommers added a commit to rgommers/array-api that referenced this issue Nov 16, 2022
@rgommers
Fix mistake in description of return dtype for matrix_rank
d57bc5d 
This was a simple mistake, not discussed in the review for the PR
that added `matrix_rank` (data-apisgh-128).

Closes data-apisgh-469
@rgommers rgommers mentioned this issue Nov 16, 2022
Merged
@rgommers rgommers added this to the v2022 milestone Nov 16, 2022
kgryte pushed a commit that referenced this issue Nov 16, 2022
@rgommers
Fix mistake in description of return dtype for matrix_rank (#510)
6d88b3f 
This was a simple mistake, not discussed in the review for the PR
that added `matrix_rank` (gh-128).

Closes gh-469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2022
Development

Successfully merging a pull request may close this issue.

Fix mistake in description of return dtype for matrix_rank rgommers/array-api
3 participants
@rgommers @kgryte @RickSanchezStoic