Skip to content

Add specification for computing singular values using singular value decomposition (linalg: svdvals) #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Apr 12, 2021

This PR

  • adds a specification for computing singular values using singular value decomposition.

Notes

  • This API deviates from current array libraries which overload the svd function modeled after NumPy via a compute_uv keyword. In that API, when compute_uv is False, only the singular values are returned. As discussed in a thread on gh-114 and in a prior weekly meeting, in order to ensure API consistency with eig and eigvals and to limit polymorphism, splitting svd into svd and svdvals was deemed desirable. The former API is equivalent to compute_uv=True, while the latter is equivalent to compute_uv=False.

@rgommers rgommers force-pushed the main branch 3 times, most recently from 0607525 to 138e963 Compare April 19, 2021 20:25
@kgryte
Copy link
Contributor Author

kgryte commented May 12, 2021

This PR has been discussed and approved during meetings. Will merge, and we can submit follow-up PRs should any issues/concerns arise.

@kgryte kgryte merged commit 3add230 into main May 12, 2021
@kgryte kgryte deleted the svdvals branch May 12, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant