Add specification for computing singular values using singular value decomposition (linalg: svdvals) #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
svd
function modeled after NumPy via acompute_uv
keyword. In that API, whencompute_uv
isFalse
, only the singular values are returned. As discussed in a thread on gh-114 and in a prior weekly meeting, in order to ensure API consistency witheig
andeigvals
and to limit polymorphism, splittingsvd
intosvd
andsvdvals
was deemed desirable. The former API is equivalent tocompute_uv=True
, while the latter is equivalent tocompute_uv=False
.