Clarify that constants are Python scalars #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
Apr 26, 2021
leofang
approved these changes
Apr 27, 2021
|
By merging this PR, I assume we can safely ignore #154? |
Don't know, could still be relevant. Would be nice to see a few more opinions on it. Let me comment on it. |
asmeurer
reviewed
Apr 27, 2021
This was referenced Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Currently, the spec does not indicate how the constants should be exposed (e.g., Python scalars, zero-dimensional arrays, etc). This PR aims to remedy this.
The choice of Python scalar, rather than as a zero-dimensional array with a dtype described in the specification, stems from greater flexibility in how these constants participate in operations.
For example, according to the current specification,
piwould be truncated when participating in an operation with an array having an integer dtype, which may not be the case ifpiwas a zero-dimensionalfloat64array and participating in mixed-type promotion.Further, as a Python scalar,
piwould be converted to afloat32array when participating in an operation with an array having afloat32dtype, which would not be the case ifpiwas a zero-dimensionalfloat64array.