Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for when factorizations and solvers are not well-defined #224

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Account for when factorizations and solvers are not well-defined #224

merged 3 commits into from
Nov 4, 2021

Conversation

lezcano
Copy link
Contributor

@lezcano lezcano commented Jul 14, 2021

@lezcano lezcano changed the title Account for when factorizations may not be well-defined Account for when factorizations and solvers are not well-defined Jul 14, 2021
kgryte
kgryte approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgommers rgommers added the topic: Linear Algebra Linear algebra. label Jul 28, 2021
@kgryte kgryte added this to the v2021 milestone Oct 4, 2021
kgryte
kgryte approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will submit a follow-up PR to address assumptions and whether an conforming library must validate those assumptions.

@kgryte kgryte merged commit 8460552 into data-apis:main Nov 4, 2021
@kgryte kgryte mentioned this pull request Nov 4, 2021
Merged
@kgryte kgryte mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@leofang leofang leofang left review comments

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2021
Development

Successfully merging this pull request may close these issues.

Some linalg functions are not well-defined
4 participants
@lezcano @rgommers @kgryte @leofang