-
Notifications
You must be signed in to change notification settings - Fork 52
Add additional element-wise mathematical functions #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kgryte. Adding these functions makes sense to me. Some minor textual comments.
I've add |
I've also added rules for floating-point arithmetic. This PR should be good to go. |
It's present, you can add it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kgryte. LGTM, modulo the "financial application" thing
Since |
I believe there's a statement somewhere already that all the different ways of spelling this must behave the same. If not, then we should indeed add it. We shouldn't say how it should be implemented though, we try hard to stay away from that and only spec syntax and semantics - if they need to be 2 or 3 independent implementations with the same behavior, that's fine. |
@rgommers Updated. Should be good to go. |
@kgryte FYI I put in a PR to Dask to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, in it goes. Thanks @kgryte
@rgommers Thanks for the update on Dask. I'll post an issue on the array-api-comparision repo. |
This PR
Notes
The list of APIs is as follows: