Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify expected behavior when providing a complex number array to nonzero #441

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Clarify expected behavior when providing a complex number array to nonzero #441

merged 1 commit into from
Jun 6, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented May 23, 2022

This PR

  • clarifies expected behavior when providing a complex number array to nonzero. Namely, nonzero elements are those elements have either a real or imaginary component (or both) which is non-zero.
  • adds a note clarifying that, for boolean arrays, True is non-zero.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels May 23, 2022
@kgryte kgryte added this to the v2022 milestone May 23, 2022
@kgryte kgryte mentioned this pull request May 23, 2022
Closed
rgommers
rgommers approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Contributor Author

kgryte commented Jun 6, 2022

Thanks, @leofang! As this PR now has two approvals and the changes are straightforward, will merge...

@kgryte kgryte merged commit 41b1b39 into main Jun 6, 2022
@kgryte kgryte deleted the cmplx-nonzero branch June 6, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@leofang leofang leofang approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
3 participants
@kgryte @rgommers @leofang