-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specification for isdtype
#503
Conversation
Based on the 3 November 2022 meeting, a few changes should be made to this PR:
|
(1) and (4) are more clear cut than (2) and (3), which make things more verbose. But I'm fine with all four of those. I do really want to see the name change to either |
I've updated the PR to incorporate the proposed changes 1-4, and I've renamed the API to This PR should be ready for another round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR
dtype
is of a specified data type kind.specifies that the function name isUpdate: based on feedback, the function name is specified asis_type
(rather thanis_dtype
) in order to matchresult_type
. Another possibility isistype
in order to matchastype
.isdtype
. The functionsastype
andresult_type
are now considered ill-named (e.g.,as_dtype
/asdtype
andresult_dtype
/common_dtype
are considered better based on present naming conventions, but are named as such due to historical reasons). The choice ofisdtype
is considered preferable overis_dtype
in order to be consistent withisfinite
,isinf
, andisnan
, which already exist in the specification. One should note that this does not follow strict PEP8 guidance; however, consistency within specification was considered preferable over PEP8 purity.dtype
, astr
, and atuple
ofdtype
andstr
.'bool'
,'signed integer'
,'unsigned integer'
,'integral'
,'real floating'
,'complex floating'
, and'numeric'
."floating"
(as described in the specification data type categories). This kind would be achieved via a tuple:('real floating', 'complex floating')
.