Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex number support to linalg.det #542

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Add complex number support to linalg.det #542

merged 1 commit into from
Dec 13, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 1, 2022

This PR

  • adds support for complex numbers to linalg.det.
  • updates the input and output array data types to be any floating-point data type, not just real-valued floating-point data types. In certain circumstances, the determinant of a complex matrix can be real-valued; however, this is not generally true. In which case, the guidance remains that the output data type be required to have the same data type as the input array x.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 1, 2022
@kgryte kgryte added this to the v2022 milestone Dec 1, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers rgommers merged commit 3f1b467 into main Dec 13, 2022
@rgommers rgommers deleted the cmplx-linalg-det branch December 13, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants