Add complex number support to linalg.qr
#548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
API change
rgommers
approved these changes
Dec 13, 2022
|
|
||
| .. note:: | ||
| Whether an array library explicitly checks whether an input array is a full column rank matrix (or a stack of full column rank matrices) is implementation-defined. | ||
|
|
||
| .. warning:: |
There was a problem hiding this comment.
This could be a note instead of a warning, in order to look less scary. That's a minor thing though, and perhaps a question of taste. So I'll leave it alone for now, just noting it in case someone revisits this PR in the future.
There was a problem hiding this comment.
Followed PyTorch in using a warning, instead of a note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
linalg.qr. The main substantive change is updating the input and output data types.