Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add complex number support to linalg.vector_norm #550

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Add complex number support to linalg.vector_norm #550

merged 1 commit into from
Dec 13, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 5, 2022

This PR

  • adds complex number support to linalg.vector_norm. The main substantive change is updating the input and output data types. For both real- and complex-valued inputs, norms (apart from ord=0) involve computing the absolute value, so no changes are necessary in norm definitions to accommodate complex numbers.
  • requires that the output data type always be a real-valued floating-point data type.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 5, 2022
@kgryte kgryte added this to the v2022 milestone Dec 5, 2022
@kgryte kgryte mentioned this pull request Dec 5, 2022
Closed
rgommers
rgommers approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward, in it goes. Thanks @kgryte

@rgommers rgommers merged commit e2eb28f into main Dec 13, 2022
@rgommers rgommers deleted the cmplx-linalg-vector-norm branch December 13, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @rgommers