Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex number support to linalg.svdvals #562

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 12, 2022

This PR

  • adds complex number support to linalg.svdvals.
  • updates the allowed input data type from real-valued floating-point to any floating-point data type.
  • requires that the output array have a real-valued floating-point data type having the same precision as the input array.
  • makes explicit that, for matrix stacks, singular values must be computed for each matrix in the stack.
  • depends on Add complex number support to linalg.svd #561.

@kgryte kgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra. labels Dec 12, 2022
@kgryte kgryte added this to the v2022 milestone Dec 12, 2022
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in it goes. The interesting bits are in the svd specification. Thanks @kgryte

@rgommers rgommers merged commit a1304fe into main Dec 14, 2022
@rgommers rgommers deleted the cmplx-linalg-svdvals branch December 14, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. topic: Linear Algebra Linear algebra.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants