Skip to content

Consolidate complex number design topics and add guidance on value-based promotion #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2022
Merged

Consolidate complex number design topics and add guidance on value-based promotion #573

merged 2 commits into from
Dec 15, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 14, 2022

This PR

@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content. topic: Complex Data Types Complex number data types. labels Dec 14, 2022
@kgryte kgryte added this to the v2022 milestone Dec 14, 2022
@kgryte kgryte requested a review from rgommers December 14, 2022 22:22
@kgryte kgryte mentioned this pull request Dec 14, 2022
Open
13 tasks
rgommers
rgommers approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @kgryte. The one added section on avoiding value-based promotion is clear, and matches the rest of the spec on type promotion.

@rgommers rgommers merged commit bb0cc71 into main Dec 15, 2022
@rgommers rgommers deleted the cmplx-design-topics branch December 15, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.

Disallow promoting real-valued inputs to complex dtypes when values are outside of their real domain
2 participants
@kgryte @rgommers