Fix definition of complex inner product in vecdot
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
approved these changes
Dec 18, 2023
|
@mtsokol Thanks for creating this PR. This relates to #616. In the workgroup meeting on 30 Nov, we discussed #616 and consensus from that meeting was to fix the definition of The proposed change should be considered a bug fix stemming from an oversight when originally adding |
kgryte
changed the title
vecdot definitionvecdot
kgryte
added
topic: Linear Algebra
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As
torch.vdot,torch.linalg.vecdotandnumpy.vdotperform conjugate on the first parameter it appears that the definition ofvecdotin the Array API is incorrect: It performs conjugate on the second parameter.This PR updates
vecdotdefinition. WDYT?