Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note concerning signed zeros #751

Merged
merged 2 commits into from
Feb 22, 2024
Merged

docs: add note concerning signed zeros #751

merged 2 commits into from
Feb 22, 2024

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Feb 21, 2024

This PR

  • closes Order of signed zeros when computing the minimum and maximum #707 by adding a note concerning signed zeros when computing the minimum and maximum value. Namely, the order of signed zeros is left unspecified and implementations may choose to return either -0 or +0 when computing the minimum/maximum.
  • explicitly allows conforming implementations to treat signed zeros as indistinguishable and avoid additional branching.

@kgryte kgryte added this to the v2023 milestone Feb 21, 2024
rgommers
rgommers approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kgryte. This LGTM modulo the minor textual issue.

rgommers
rgommers approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM now, and there was agreement on the content of the note in the linked issue, so in it goes. Thanks @kgryte

@rgommers rgommers merged commit 6e9c487 into data-apis:main Feb 22, 2024
@rgommers rgommers added the Maintenance Bug fix, typo fix, or general maintenance. label Feb 22, 2024
@kgryte kgryte deleted the min-max-signed-zeros branch February 22, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Milestone
v2023
Development

Successfully merging this pull request may close these issues.

Order of signed zeros when computing the minimum and maximum
2 participants
@kgryte @rgommers