Skip to content

Don't let Column.name be None #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Don't let Column.name be None #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57f0dbb
unnunnable-ify name
MarcoGorelli Aug 2, 2023
12779e3
allow default empty string name
MarcoGorelli Aug 3, 2023
3c4c4bf
optionality
MarcoGorelli Aug 3, 2023
361164b
fixup
MarcoGorelli Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/API_specification/dataframe_api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def concat(dataframes: Sequence[DataFrame]) -> DataFrame:
"""
...

def column_from_sequence(sequence: Sequence[Any], *, name: str | None, dtype: Any) -> Column[Any]:
def column_from_sequence(sequence: Sequence[Any], *, dtype: Any, name: str = '') -> Column[Any]:
"""
Construct Column from sequence of elements.

Expand Down Expand Up @@ -108,7 +108,7 @@ def dataframe_from_dict(data: Mapping[str, Column[Any]]) -> DataFrame:
...


def column_from_1d_array(array: Any, *, name: str, dtype: Any) -> Column[Any]:
def column_from_1d_array(array: Any, *, dtype: Any, name: str = '') -> Column[Any]:
"""
Construct Column from 1D array.

Expand All @@ -122,7 +122,7 @@ def column_from_1d_array(array: Any, *, name: str, dtype: Any) -> Column[Any]:
----------
array : array
array-API compliant 1D array
name : str
name : str, optional
Name to give columns.
dtype : DType
Dtype of column.
Expand Down
4 changes: 2 additions & 2 deletions spec/API_specification/dataframe_api/column_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def column(self) -> Any:
...

@property
def name(self) -> str | None:
def name(self) -> str:
"""Return name of column."""

def __len__(self) -> int:
Expand Down Expand Up @@ -711,7 +711,7 @@ def to_array_object(self, dtype: Any) -> Any:
``array-api-compat`` package to convert it to a Standard-compliant array.
"""

def rename(self, name: str | None) -> Column[DType]:
def rename(self, name: str) -> Column[DType]:
"""
Rename column.

Expand Down