Skip to content

Rename insert, remove label argument #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2023
Merged

Rename insert, remove label argument #230

merged 1 commit into from
Aug 22, 2023

Conversation

@MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Aug 21, 2023

There's a couple of things I don't like about DataFrame.insert:

  • the name is less descriptive than the rest of the API
  • the argument label isn't really needed, because we have both Column.name and Column.rename

kkraus14
kkraus14 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rgommers
rgommers approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@MarcoGorelli
Copy link
Contributor Author

MarcoGorelli commented Aug 22, 2023

thanks all

@MarcoGorelli MarcoGorelli merged commit cafa8fd into data-apis:main Aug 22, 2023
@MarcoGorelli MarcoGorelli mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

No one assigned

Labels

API design

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcoGorelli @rgommers @kkraus14