Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #235
I think I made a mistake in splitting "set_column" into "insert_column" and "update_column":
set_column_by_name
/set_column
? #235)In keeping with the goal of making the standard feel familiar, let's look at what existing dataframe libraries do:
__setitem__
(which the consortium doesn't want) orDataFrame.assign
DataFrame.with_columns
DataFrame.mutate
update / extend
I don't really mind which one we go with. I'm suggesting
with_columns
here as I think it's probably the most explicit