Skip to content

rename get_column_by_name to col #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 26, 2023
Merged

Conversation

MarcoGorelli
Copy link
Contributor

closes #287

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 to this, but would prefer if we brought this up in the next meeting before merging. Thanks!

@MarcoGorelli
Copy link
Contributor Author

MarcoGorelli commented Oct 23, 2023

sure, will wait, thanks

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, I think we inherited the get_column_by_name method naming from the interchange protocol. For that protocol, usage is kind of a "one shot" thing, where you may use a few methods when doing a conversion, but it's not like you write a whole library using that API. There is no real reason why we have to keep names that are in the interchange protocol, and get_column_by_name is particularly cumbersome, so +1 to renaming. Any reasonable and ergonomic name works here (.col, .get_col, etc.), so +1 from me.

The one thing to keep in mind for future renames is probably that we should avoid having method names that are also part of the protocol if the semantics are different. But that doesn't seem too likely.

@MarcoGorelli
Copy link
Contributor Author

approved in today's call too - thanks all, let's get this in and make things happen

@MarcoGorelli MarcoGorelli merged commit 3b51f71 into data-apis:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: get_column_by_name impairs readability
4 participants