-
Notifications
You must be signed in to change notification settings - Fork 21
rename get_column_by_name to col #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 to this, but would prefer if we brought this up in the next meeting before merging. Thanks!
sure, will wait, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, I think we inherited the get_column_by_name
method naming from the interchange protocol. For that protocol, usage is kind of a "one shot" thing, where you may use a few methods when doing a conversion, but it's not like you write a whole library using that API. There is no real reason why we have to keep names that are in the interchange protocol, and get_column_by_name
is particularly cumbersome, so +1 to renaming. Any reasonable and ergonomic name works here (.col
, .get_col
, etc.), so +1 from me.
The one thing to keep in mind for future renames is probably that we should avoid having method names that are also part of the protocol if the semantics are different. But that doesn't seem too likely.
approved in today's call too - thanks all, let's get this in and make things happen |
closes #287