Add note about parent dataframes and cross-dataframe column comparisons #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
note-about-parent-dataframes
branch
from
eacc116 to
e362b88
Compare
kkraus14
reviewed
Nov 1, 2023
…ather than impossibility
kkraus14
reviewed
Nov 14, 2023
kkraus14
approved these changes
Nov 14, 2023
|
Thanks for your careful review, much appreciated 🙏 Leaving open a bit longer in case others have objections, then will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can relax many of these restrictions for the case of free-standing columns (i.e. those without a parent dataframe, created via
column_from_1d_array) - just working through it to check, will update this week