Clarify dtype type in ColumnBuffers
elements
#87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this team's efforts in implementing the dataframe interchange protocol.
While experimenting on an implementation for StaticFrame (static-frame/static-frame#621), I found one aspect of the ABC and associated types unclear.
The
ColumnBuffers
TypedDict
defines its elements as pairs ofBuffer
and a dtype, but only types the dtype asAny
. I assume that the dtype should be provided as the same tuple returned fromColumn.dtype
. This PR makes this explicit by defining aDtype
type alias and using it for the return value ofColumn.dtype
as well as the elements inColumnBuffers
.If my assumption is incorrect, it would be helpful to specify the type of the dtype values returned from
ColumnBuffers
.