Skip to content

Commit

Permalink
resolve unnecessary dependency in git_release role (#623)
Browse files Browse the repository at this point in the history
### Feature or Bugfix
- Bugfix

### Detail
- Remove small bug on the way we define the git release role - managed
policies are attached after role creation
- NOTE: The fix is already included in the `modularization-main` branch

### Relates
-  #617 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
dlpzx authored Aug 8, 2023
1 parent c678e67 commit 8900ebf
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion deploy/stacks/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ def set_codebuild_iam_roles(self):
iam.ServicePrincipal('codebuild.amazonaws.com'),
iam.AccountPrincipal(self.account),
),
managed_policies=[self.baseline_codebuild_policy, self.git_release_policy, self.expanded_codebuild_policy]
)
self.expanded_codebuild_policy.attach_to_role(self.git_project_role)
self.baseline_codebuild_policy.attach_to_role(self.git_project_role)
Expand Down

0 comments on commit 8900ebf

Please sign in to comment.