Fix issue with duplicate resources - backwards compatibility

data-dot-all · Apr 18, 2023 · bc3d154 · bc3d154
1 parent 3f456fa
commit bc3d154
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/backend/dataall/cdkproxy/stacks/sagemakerstudio.py b/backend/dataall/cdkproxy/stacks/sagemakerstudio.py
@@ -42,7 +42,7 @@ def check_existing_sagemaker_studio_domain(self, environment: models.Environment
             )
             dataall_created_domain = ParameterStoreManager.client(
                 AwsAccountId=environment.AwsAccountId, region=environment.region, role=cdk_look_up_role_arn
-            ).get_parameter(Name=f'/dataall/{environment.environmentUri}/sagemaker/sagemakerstudio/domain_id')
+            ).get_parameter(Name=f'/dataall/{environment.environmentUri}/sagemaker/sagemakerstudio/domainId')
             return False
         except ClientError as e:
             logger.info(f'check sagemaker studio domain created outside of data.all. Parameter data.all not found: {e}')
@@ -62,7 +62,7 @@ def __init__(self, scope: Construct, construct_id: str, environment: models.Envi
                 self,
                 'RoleForSagemakerStudioUsers',
                 assumed_by=iam.ServicePrincipal('sagemaker.amazonaws.com'),
-                role_name='RoleSagemakerStudioUsers',
+                role_name='RoleForSagemakerStudioUsers',
                 managed_policies=[
                     iam.ManagedPolicy.from_managed_policy_arn(
                         self,
@@ -117,7 +117,7 @@ def __init__(self, scope: Construct, construct_id: str, environment: models.Envi
                 self,
                 'SagemakerStudioDomainId',
                 string_value=sagemaker_domain.attr_domain_id,
-                parameter_name=f'/dataall/{self._environment.environmentUri}/sagemaker/sagemakerstudio/domain_id',
+                parameter_name=f'/dataall/{self._environment.environmentUri}/sagemaker/sagemakerstudio/domainId',
             )