Skip to content

Commit

Permalink
Update Lambda runtime (#782)
Browse files Browse the repository at this point in the history
### Feature or Bugfix
Update

### Detail


### Relates
See #655: 
> In Nov 27, 2023 the Lambda runtime node14 and Python3.7 will be
deprecated!

Checked all lambdas that explicitly set the runtime engine: only cognito
httpheader redirection lambda used node14.
All lambdas use python3.8 and node16 or node18.

For cdk dependencies: upgraded to a newest `aws-cdk-lib` `v2.99.0` just
in case if python3.7 is hardcoded somewhere inside of 2.78.0 (shouldn't
be)

### 
Testing: 
- [x] uploaded the changes to my isengard account
- [x] deployment is green 
- [x] could access app page, userguide page, and userguide from the app
page.

### Security
`N/A` - upgraded to a newer version of node js

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
nikpodsh authored Oct 10, 2023
1 parent 16c7026 commit c61ba15
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion backend/dataall/base/cdkproxy/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
aws-cdk-lib==2.83.1
aws-cdk-lib==2.99.0
boto3==1.24.85
boto3-stubs==1.24.85
botocore==1.27.85
Expand Down
2 changes: 1 addition & 1 deletion deploy/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
aws-cdk-lib==2.78.0
aws-cdk-lib==2.99.0
boto3-stubs==1.20.20
boto3==1.24.85
botocore==1.27.85
Expand Down
2 changes: 1 addition & 1 deletion deploy/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
author=__author__,
package_dir={'': 'stacks'},
packages=setuptools.find_packages(where='stacks'),
python_requires='>=3.7',
python_requires='>=3.8',
)
2 changes: 1 addition & 1 deletion deploy/stacks/cloudfront.py
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ def build_docs_http_headers(self, docs_http_headers, envname, resource_prefix):
iam.ServicePrincipal('lambda.amazonaws.com'),
),
),
runtime=_lambda.Runtime.NODEJS_14_X,
runtime=_lambda.Runtime.NODEJS_18_X,
)

http_header_func_version = http_header_func.current_version
Expand Down

0 comments on commit c61ba15

Please sign in to comment.