Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable/Enabled Metrics tab in table page view #1570

Open
TejasRGitHub opened this issue Sep 23, 2024 · 0 comments
Open

Disable/Enabled Metrics tab in table page view #1570

TejasRGitHub opened this issue Sep 23, 2024 · 0 comments
Labels

Comments

@TejasRGitHub
Copy link
Contributor

TejasRGitHub commented Sep 23, 2024

Is your idea related to a problem? Please describe.
Since we don't use and don't want users to press on the profiling button , we want to hide the "Metrics" tab in the table page view with the is_feature_enabled function

Describe the solution you'd like
Use feature flags like how they are used in the s3_datasets section to enable/ disable the "Metrics" tab.

Proposing a config like

"s3_datasets": {
            "active": true,
            "features": {
                "file_uploads": true,
                "file_actions": true,
                 ....,
                 "metrics_data": true/false
                
            

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

@dlpzx dlpzx added this to v2.7.0 Sep 25, 2024
@github-project-automation github-project-automation bot moved this to Nominated in v2.7.0 Sep 25, 2024
@dlpzx dlpzx added type: enhancement Feature enhacement effort: low labels Sep 25, 2024
@dlpzx dlpzx moved this from Nominated to Review in progress in v2.7.0 Sep 25, 2024
TejasRGitHub pushed a commit to TejasRGitHub/aws-dataall that referenced this issue Sep 25, 2024
dlpzx pushed a commit that referenced this issue Sep 25, 2024
### Feature or Bugfix
- Feature


### Detail

Using existing functions like is_feature_enabled to enabled / disable
use of metrics and associated profiling jobs.

### Relates

- #1570

### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)? N/A
  - Is the input sanitized? 
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization? N/A
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features? No
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users? No
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: trajopadhye <tejas.rajopadhye@yahooinc.com>
@dlpzx dlpzx moved this from Review in progress to Done in v2.7.0 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants