Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to view logs in ECS share manager logs with code from main #1680

Closed
TejasRGitHub opened this issue Nov 1, 2024 · 5 comments · Fixed by #1709
Closed

Unable to view logs in ECS share manager logs with code from main #1680

TejasRGitHub opened this issue Nov 1, 2024 · 5 comments · Fixed by #1709
Assignees

Comments

@TejasRGitHub
Copy link
Contributor

TejasRGitHub commented Nov 1, 2024

Describe the bug

git clone / git merge code from main branch.
Deploy and make a share
The share logs do not appear to be present and only few log line are present.

image

How to Reproduce

*P.S. Please do not attach files as it's considered a security risk. Add code snippets directly in the message body as much as possible.*

git clone / git merge code from main branch.
Deploy and make a share
The share logs do not appear to be present and only few log line are present.

Expected behavior

Logs from the share manager's methods like approve_share or revoke_share should be present

Your project

No response

Screenshots

No response

OS

Mac

Python version

3.9

AWS data.all version

main branch code

Additional context

No response

@noah-paige
Copy link
Contributor

noah-paige commented Nov 4, 2024

Hi @TejasRGitHub - this is from latest code on main and not release branch correct?

There is a recent PR that alters with log levels a bit for prod_sizing: true deployments : #1662

Can you share what env variables are there for the share manger ECS task?

@TejasRGitHub
Copy link
Contributor Author

Hi @noah-paige ,

This code is from the main branch.

Here's the env variables from ECS. Hiding some custom variables we use
image

@noah-paige
Copy link
Contributor

2 things:

  • Can you adjust LOG_LEVEL to DEBUG and re-run to see if it adjusts back to as expected
  • Confirming for this deployment you set prod_sizing to True ?

@TejasRGitHub
Copy link
Contributor Author

  • Can you adjust LOG_LEVEL to DEBUG and re-run to see if it adjusts back to as expected ( I tried adding this but this didn't work. I changed logger setting to what it was previously and it started to work again.
image
  • Confirming for this deployment you set prod_sizing to True ? Yes

@noah-paige
Copy link
Contributor

@dlpzx - can you take a look at the above and provide some insight on the logging changes made?

@dlpzx dlpzx self-assigned this Nov 13, 2024
@dlpzx dlpzx added this to v2.7.0 Nov 13, 2024
@github-project-automation github-project-automation bot moved this to Nominated in v2.7.0 Nov 13, 2024
@dlpzx dlpzx moved this from Nominated to In progress in v2.7.0 Nov 13, 2024
@noah-paige noah-paige linked a pull request Nov 20, 2024 that will close this issue
dlpzx pushed a commit that referenced this issue Nov 26, 2024
### Feature or Bugfix
<!-- please choose -->
- Refactoring

### Detail
-  Unify Logger Config in Backend (focused on `/tasks`)
-  Fix Log Level setting

### Relates
- #1680
- #1662
### Security
Please answer the questions below briefly where applicable, or write
`N/A`. Based on
[OWASP 10](https://owasp.org/Top10/en/).

- Does this PR introduce or modify any input fields or queries - this
includes
fetching data from storage outside the application (e.g. a database, an
S3 bucket)?
  - Is the input sanitized?
- What precautions are you taking before deserializing the data you
consume?
  - Is injection prevented by parametrizing queries?
  - Have you ensured no `eval` or similar functions are used?
- Does this PR introduce any functionality or component that requires
authorization?
- How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  - Are you logging failed auth attempts?
- Are you using or adding any cryptographic features?
  - Do you use a standard proven implementations?
  - Are the used keys controlled by the customer? Where are they stored?
- Are you introducing any new policies/roles/users?
  - Have you used the least-privilege principle? How?


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@github-project-automation github-project-automation bot moved this from In progress to Done in v2.7.0 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants