-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to view logs in ECS share manager logs with code from main #1680
Comments
Hi @TejasRGitHub - this is from latest code on There is a recent PR that alters with log levels a bit for Can you share what env variables are there for the share manger ECS task? |
Hi @noah-paige , This code is from the Here's the env variables from ECS. Hiding some custom variables we use |
2 things:
|
@dlpzx - can you take a look at the above and provide some insight on the logging changes made? |
### Feature or Bugfix <!-- please choose --> - Refactoring ### Detail - Unify Logger Config in Backend (focused on `/tasks`) - Fix Log Level setting ### Relates - #1680 - #1662 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Describe the bug
git clone / git merge code from main branch.
Deploy and make a share
The share logs do not appear to be present and only few log line are present.
How to Reproduce
git clone / git merge code from main branch.
Deploy and make a share
The share logs do not appear to be present and only few log line are present.
Expected behavior
Logs from the share manager's methods like
approve_share
orrevoke_share
should be presentYour project
No response
Screenshots
No response
OS
Mac
Python version
3.9
AWS data.all version
main branch code
Additional context
No response
The text was updated successfully, but these errors were encountered: